linux-kernel - Re: [patch] dma/timberdale: free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1317963525.1573.2227.camel@vkoul-udesk3>
Date:	Fri, 07 Oct 2011 10:28:45 +0530
From:	Vinod Koul <vinod.koul@...el.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Dan Williams <dan.j.williams@...el.com>,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] dma/timberdale: free_irq() on an error path

On Fri, 2011-09-23 at 09:16 +0300, Dan Carpenter wrote:
> There was an error path that skipped the free_irq() step by mistake.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> 
> diff --git a/drivers/dma/timb_dma.c b/drivers/dma/timb_dma.c
> index 6dbdf45..a4a398f 100644
> --- a/drivers/dma/timb_dma.c
> +++ b/drivers/dma/timb_dma.c
> @@ -762,7 +762,7 @@ static int __devinit td_probe(struct platform_device *pdev)
>  		if ((i % 2) == pchan->rx) {
>  			dev_err(&pdev->dev, "Wrong channel configuration\n");
>  			err = -EINVAL;
> -			goto err_tasklet_kill;
> +			goto err_free_irq;
>  		}
>  
>  		td_chan->chan.device = &td->dma;
Applied thanks

-- 
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/