linux-kernel - Re: [PATCH] tg3: Dont dump registers if interface not ready.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E8FC19F.9060305@oracle.com>
Date:	Sat, 08 Oct 2011 11:21:03 +0800
From:	Joe Jin <joe.jin@...cle.com>
To:	Matt Carlson <mcarlson@...adcom.com>
CC:	Xiao Jiang <jgq516@...il.com>, Michael Chan <mchan@...adcom.com>,
	Guru Anbalagane <guru.anbalagane@...cle.com>,
	Gurudas Pai <gurudas.pai@...cle.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Greg Marsden <greg.marsden@...cle.com>
Subject: Re: [PATCH] tg3: Dont dump registers if interface not ready.

>>>  
>>> +	/* If interface not ready then dont dump error */
>>> +	if (!netif_carrier_ok(tp->dev))
>>> +		dump = false;
> 
> Would you still experience the problem if you did the following instead
> of the above link check?
> 
> 		if (tg3_flag(tp, INIT_COMPLETE))
> 			dump = false;

I'll try it then update you.

Thanks,
Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/