linux-kernel - Re: Subject: [PATCH]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1318098206.1844.3.camel@Joe-Laptop>
Date:	Sat, 08 Oct 2011 11:23:26 -0700
From:	Joe Perches <joe@...ches.com>
To:	Jake Burton <jake5991@...e.com>
Cc:	gregkh@...e.de, abbotti@....co.uk, fmhess@...rs.sourceforge.net,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: Subject: [PATCH]

On Sat, 2011-10-08 at 19:01 +0100, Jake Burton wrote:
> diff --git a/drivers/staging/comedi/drivers/ni_atmio.c b/drivers/staging/comedi/drivers/ni_atmio.c
[]
> @@ -279,7 +279,7 @@ static const int ni_irqpin[] =
>  
>  struct ni_private {
>  	struct pnp_dev *isapnp_dev;
> - NI_PRIVATE_COMMON};
> +NI_PRIVATE_COMMON};

Hard to believe this is better.  Maybe:

struct ni_private {
	struct pnp_dev *isapnp_dev;
	NI_PRIVATE_COMMON
};

It'd be better to inline NI_PRIVATE_COMMON,
whatever that is.  There are 3 uses of that
really ugly #define.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/