linux-kernel - Re: [PATCH 2/2] ext4: MMP: fix error message rate-limiting logic in kmmpd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111008212519.GO7948@thunk.org>
Date:	Sat, 8 Oct 2011 17:25:19 -0400
From:	Ted Ts'o <tytso@....edu>
To:	Nikitas Angelinas <nikitasangelinas@...il.com>
Cc:	adilger.kernel@...ger.ca, adilger@...mcloud.com,
	johann@...mcloud.com, linux-ext4@...r.kernel.org,
	linux-kernel@...r.kernel.org, nikitas_angelinas@...atex.com,
	andrew_perepechko@...atex.com
Subject: Re: [PATCH 2/2] ext4: MMP: fix error message rate-limiting logic
 in kmmpd

On Fri, Sep 30, 2011 at 12:38:20AM +0100, Nikitas Angelinas wrote:
> Current logic would print an error message only once, and then
> 'failed_writes' would stay at 1. Rework the loop to increment
> 'failed_writes' and print the error message every s_mmp_update_interval
> * 60 seconds, as intended according to the comment.
> 
> Perhaps it would be better to reset 'failed_writes' to 0 on every
> successful write, such that new errors are noticed sooner, but maybe in
> the interest of efficiency it would be best not to add an operation on
> every kmmpd thread run?
> 
> Signed-off-by: Nikitas Angelinas <nikitas_angelinas@...atex.com>
> Signed-off-by: Andrew Perepechko <andrew_perepechko@...atex.com>
> Acked-by: Andreas Dilger <adilger@...ger.ca>

Thanks, applied.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/