lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 8 Oct 2011 18:24:07 +0800 From: Eric Miao <eric.y.miao@...il.com> To: Jamie Iles <jamie@...ieiles.com> Cc: Russell King - ARM Linux <linux@....linux.org.uk>, Jason Chagas <jason.chagas@...vell.com>, Haojian Zhuang <haojian.zhuang@...vell.com>, linux-arm-kernel@...ts.infradead.org, Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 06/26] ARM: pxa: add missing header inclusions On Sat, Oct 8, 2011 at 6:23 PM, Jamie Iles <jamie@...ieiles.com> wrote: > On Sat, Oct 08, 2011 at 09:03:09AM +0100, Russell King - ARM Linux wrote: >> On Fri, Oct 07, 2011 at 01:08:23PM +0800, Eric Miao wrote: >> > On Sun, Oct 2, 2011 at 4:03 AM, Arnd Bergmann <arnd@...db.de> wrote: >> > > These resulted in build breakage in some configurations: >> > > >> > > arch/arm/mach-pxa/irq.c:132:39: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'icip_handle_irq' >> > > >> > > Signed-off-by: Arnd Bergmann <arnd@...db.de> >> > > --- >> > > arch/arm/mach-pxa/irq.c | 1 + >> > > 1 files changed, 1 insertions(+), 0 deletions(-) >> > > >> > > diff --git a/arch/arm/mach-pxa/irq.c b/arch/arm/mach-pxa/irq.c >> > > index b09e848..848e96d 100644 >> > > --- a/arch/arm/mach-pxa/irq.c >> > > +++ b/arch/arm/mach-pxa/irq.c >> > > @@ -16,6 +16,7 @@ >> > > #include <linux/module.h> >> > > #include <linux/interrupt.h> >> > > #include <linux/syscore_ops.h> >> > > +#include <linux/ftrace.h> >> > >> > It's actually __irq_entry being defined in <linux/ftrace.h> and in turn >> > __exception_irq_entry being conditionally defined to that. >> > >> > I think it's better to fix this in <asm/system.h> instead of in the >> > cases where this macro is referenced? >> > >> > Russell? >> >> There's a patch in the patch system which fixes this (7115/3) but I >> can't apply it because it doesn't apply to anything in my for-next >> tree (it applies to the obsolete 'devel' branch which is rather old >> now.) > > OK, I wasn't aware that devel was obsolete (though I guess if I'd paid > closer attention to the commit dates I'd have suspected something). > > Anyhow, new patch in the tracker as 7115/4 rebased onto for-next. Thanks, Jamie. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists