linux-kernel - Re: [PATCH -next] usb gadget: fix langwell

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111009223638.GA29776@legolas.emea.dhcp.ti.com>
Date:	Mon, 10 Oct 2011 01:36:40 +0300
From:	Felipe Balbi <balbi@...com>
To:	Randy Dunlap <rdunlap@...otime.net>
Cc:	balbi@...com, Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	linux-usb@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH -next] usb gadget: fix langwell_udc.c build error

Hi,

On Sun, Oct 09, 2011 at 10:50:56AM -0700, Randy Dunlap wrote:
> On 10/08/11 03:03, Felipe Balbi wrote:
> > Hi,
> > 
> > On Fri, Oct 07, 2011 at 01:57:42PM -0700, Randy Dunlap wrote:
> >> From: Randy Dunlap <rdunlap@...otime.net>
> >>
> >> Move function to fix langwell_udc.c build error:
> >>
> >> drivers/usb/gadget/langwell_udc.c: In function 'show_langwell_udc':
> >> drivers/usb/gadget/langwell_udc.c:1693:3: error: implicit declaration of function 'lpm_device_speed'
> >> drivers/usb/gadget/langwell_udc.c: At top level:
> >> drivers/usb/gadget/langwell_udc.c:2637:37: error: conflicting types for 'lpm_device_speed'
> >> drivers/usb/gadget/langwell_udc.c:1693:20: note: previous implicit declaration of 'lpm_device_speed' was here
> > 
> > I don't have this compile error on my branch, did something go in
> > without me noticing ?
> 
> probably not.  What version of gcc are you using?

I believe it did, I don't have lpm_device_speed() at all.

> I'm using 4.5.1.

4.6.1

> > Can you blame a comit which introduced this ?
> 
> I don't see such a commit.

$ git log --pretty=oneline -S'lpm_device_speed' HEAD --	\
	drivers/usb/gadget/langwell_udc.c

what's the output ?

> > btw, all I have is a warning.
> 
> What warning?

drivers/usb/gadget/langwell_udc.c: In function ‘langwell_ep_dequeue’:
drivers/usb/gadget/langwell_udc.c:919:11: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)