linux-kernel - Re: [PATCH 1/2 v3] udf : enable error print in udf_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1318136188.1844.56.camel@Joe-Laptop>
Date:	Sat, 08 Oct 2011 21:56:28 -0700
From:	Joe Perches <joe@...ches.com>
To:	NamJae Jeon <linkinjeon@...il.com>
Cc:	Jan Kara <jack@...e.cz>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2 v3] udf : enable error print in udf_read_tagged().

On Sun, 2011-10-09 at 13:44 +0900, NamJae Jeon wrote:
> 2011/10/9 Joe Perches <joe@...ches.com>:
> > Not a good patch I think.
> > You've broken format strings when they should be coalesced
> > and the alignment looks odd.
> Would you explain more ? I didn't understand your meaning yet.

Format strings are allowed to exceed 80 columns.
Arguments should be aligned to the open parenthesis

For example:
	pr_err("some really long format string longer than "
		"80 columns and not broken into pieces, Count: %d\n",
		count);
is better as:
	pr_err("some really long format string longer than 80 columns and not broken into pieces, Count: %d\n",
	       count);

Coalesced format strings makes dmesg output easier to grep.
count is not indented by 2 tabs, but 1 tab and 7 spaces.

There's no hard and fast rule on the indentation.

The patch I sent coalesced all format strings and
used that alignment style.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/