linux-kernel - Re: [PATCH v4 00/11] KVM: x86: optimize for writing guest page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E91A3AA.1000309@redhat.com>
Date:	Sun, 09 Oct 2011 15:37:46 +0200
From:	Avi Kivity <avi@...hat.com>
To:	Xiao Guangrong <xiaoguangrong@...fujitsu.com>
CC:	Marcelo Tosatti <mtosatti@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>, KVM <kvm@...r.kernel.org>
Subject: Re: [PATCH v4 00/11] KVM: x86: optimize for writing guest page

On 10/09/2011 02:24 PM, Avi Kivity wrote:
> On 10/08/2011 06:06 AM, Xiao Guangrong wrote:
>> On 10/07/2011 01:53 AM, Marcelo Tosatti wrote:
>> >  On Thu, Sep 22, 2011 at 04:52:40PM +0800, Xiao Guangrong wrote:
>> >>  This patchset is against https://github.com/avikivity/kvm.git 
>> next branch.
>> >>
>> >>  In this version, some changes come from Avi's comments:
>> >>  - fix instruction retried for nested guest
>> >>  - skip write-flooding for the sp whose level is 1
>> >>  - rename some functions
>> >
>> >  Please rebase.
>> >
>> >
>>
>> Marcelo,
>>
>> These patches can be applied without any conflict and it also works 
>> well,
>> the current code was pulled from https://github.com/avikivity/kvm.git 
>> next branch.
>>
>> What problem did you meet when you applied these? :(
>
> I guess it was a user error - it applies cleanly here too (and pushed 
> to next, thanks).
>

However, it seems to reduce performance.

Autotest results before:

Test                                        Status     Seconds  Info
----                                        ------     -------  ----
         (Result file: ../../results/default/status)
unittest                                    GOOD       147      
completed successfully
Fedora.9.32.install.smp2                    GOOD       865      
completed successfully
Fedora.9.32.boot.smp2                       GOOD       46       
completed successfully
Fedora.9.32.reboot.smp2                     GOOD       49       
completed successfully
Fedora.9.32.shutdown.smp2                   GOOD       15       
completed successfully
Fedora.9.64.install.smp2                    GOOD       943      
completed successfully
Fedora.9.64.boot.smp2                       GOOD       47       
completed successfully
Fedora.9.64.reboot.smp2                     GOOD       48       
completed successfully
Fedora.9.64.shutdown.smp2                   GOOD       14       
completed successfully
WinXP.32.install.smp2                       GOOD       772      
completed successfully
WinXP.32.setup.smp2                         GOOD       53       
completed successfully
WinXP.32.boot.smp2                          GOOD       57       
completed successfully
WinXP.32.reboot.smp2                        GOOD       34       
completed successfully
WinXP.32.shutdown.smp2                      GOOD       5        
completed successfully
WinXP.64.install.smp2                       GOOD       636      
completed successfully


After:

unittest                                    GOOD       150      
completed successfully
Fedora.9.32.install.smp2                    GOOD       879      
completed successfully
Fedora.9.32.boot.smp2                       GOOD       50       
completed successfully
Fedora.9.32.reboot.smp2                     GOOD       48       
completed successfully
Fedora.9.32.shutdown.smp2                   GOOD       15       
completed successfully
Fedora.9.64.install.smp2                    GOOD       997      
completed successfully
Fedora.9.64.boot.smp2                       GOOD       47       
completed successfully
Fedora.9.64.reboot.smp2                     GOOD       48       
completed successfully
Fedora.9.64.shutdown.smp2                   GOOD       14       
completed successfully
WinXP.32.install.smp2                       GOOD       764      
completed successfully
WinXP.32.setup.smp2                         GOOD       51       
completed successfully
WinXP.32.boot.smp2                          GOOD       40       
completed successfully
WinXP.32.reboot.smp2                        GOOD       34       
completed successfully
WinXP.32.shutdown.smp2                      GOOD       5        
completed successfully
WinXP.64.install.smp2                       GOOD       666      
completed successfully


-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/