linux-kernel - Re: [PATCH 1/2 v3] udf : enable error print in udf_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 9 Oct 2011 23:07:28 +0900
From:	NamJae Jeon <linkinjeon@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Jan Kara <jack@...e.cz>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2 v3] udf : enable error print in udf_read_tagged().

2011/10/9 NamJae Jeon <linkinjeon@...il.com>:
> 2011/10/9 Joe Perches <joe@...ches.com>:
>> On Sun, 2011-10-09 at 13:44 +0900, NamJae Jeon wrote:
>>> 2011/10/9 Joe Perches <joe@...ches.com>:
>>> > Not a good patch I think.
>>> > You've broken format strings when they should be coalesced
>>> > and the alignment looks odd.
>>> Would you explain more ? I didn't understand your meaning yet.
>>
>> Format strings are allowed to exceed 80 columns.
>> Arguments should be aligned to the open parenthesis
>>
>> For example:
>>        pr_err("some really long format string longer than "
>>                "80 columns and not broken into pieces, Count: %d\n",
>>                count);
>> is better as:
>>        pr_err("some really long format string longer than 80 columns and not broken into pieces, Count: %d\n",
>>               count);
>>
>> Coalesced format strings makes dmesg output easier to grep.
>> count is not indented by 2 tabs, but 1 tab and 7 spaces.
>>
>> There's no hard and fast rule on the indentation.
>>
>> The patch I sent coalesced all format strings and
>> used that alignment style.
> Clear~ I will do it as your guide.
> Thanks very much. joe~

Hi. joe.
I attach v5 patch.
plz review it.
Thanks.
>>
>>
>

Download attachment "0001-udf-enable-error-print-in-udf_read_tagged.patch" of type "application/octet-stream" (59455 bytes)