[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CACRpkdbVd89OeyUL0Y9XaFhJqVLeSHimYwSBREZyO0xnGH=U0Q@mail.gmail.com>
Date: Mon, 10 Oct 2011 13:05:36 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Samuel Ortiz <sameo@...ux.intel.com>
Cc: Linus Walleij <linus.walleij@...ricsson.com>,
linux-kernel@...r.kernel.org, Lee Jones <lee.jones@...aro.org>,
Mattias Nilsson <mattias.i.nilsson@...ricsson.com>
Subject: Re: [PATCH 09/23] mfd/db8500-prcmu: tweak for modem wakeup
On Mon, Oct 10, 2011 at 12:31 PM, Samuel Ortiz <sameo@...ux.intel.com> wrote:
> Hi Linus,
>> > if (!wait_for_completion_timeout(&mb0_transfer.ac_wake_work,
>> > - msecs_to_jiffies(20000))) {
>> > - pr_err("prcmu: %s timed out (20 s) waiting for a reply.\n",
>> > + msecs_to_jiffies(5000))) {
>> > + panic("prcmu: %s timed out (5 s) waiting for a reply.\n",
>> > + __func__);
>> panic(), really ?
>
> What about this one. Do we really want to panic here ?
Oh I must have lost that patch I wrote converting them all
to pr_crit(). Just sent it out, sorry about this.
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists