linux-kernel - Re: [PATCH] PM: HIBERNATION: add resume_delay kernel param as well as resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 10 Oct 2011 14:34:45 +0800
From:	Barry Song <21cnbao@...il.com>
To:	Borislav Petkov <bp@...en8.de>, Barry Song <Barry.Song@....com>,
	pavel@....cz, rjw@...k.pl, linux-pm@...ts.linux-foundation.org,
	linux-mmc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, workgroup.linux@....com,
	Barry Song <baohua.song@....com>
Subject: Re: [PATCH] PM: HIBERNATION: add resume_delay kernel param as well as resume_delay

2011/10/10 Borislav Petkov <bp@...en8.de>:
> On Sun, Oct 09, 2011 at 10:44:12PM -0700, Barry Song wrote:
>> From: Barry Song <baohua.song@....com>
>>
>> patch "PM: HIBERNATION: add resume_wait param to support MMC-like devices
>> as resume file" add resume_wait param. this patch adds resume_delay so that
>> resume_wait/delay has the same model with root_wait/delay.
>>
>> Signed-off-by: Barry Song <baohua.song@....com>
>> ---
>>  Documentation/kernel-parameters.txt |    3 +++
>>  kernel/power/hibernate.c            |   14 ++++++++++++++
>>  2 files changed, 17 insertions(+), 0 deletions(-)
>>
>> diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
>> index 88a7b19..831bde2 100644
>> --- a/Documentation/kernel-parameters.txt
>> +++ b/Documentation/kernel-parameters.txt
>> @@ -2240,6 +2240,9 @@ bytes respectively. Such letter suffixes can also be entirely omitted.
>>                       in <PAGE_SIZE> units (needed only for swap files).
>>                       See  Documentation/power/swsusp-and-swap-files.txt
>>
>> +     resumedelay=    [HIBERNATION] Delay (in seconds) to pause before attempting to
>> +                     read the resume files
>> +
>>       resumewait      [HIBERNATION] Wait (indefinitely) for resume device to show up.
>>                       Useful for devices that are detected asynchronously
>>                       (e.g. USB and MMC devices).
>> diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c
>> index b3da53c..f73a00e 100644
>> --- a/kernel/power/hibernate.c
>> +++ b/kernel/power/hibernate.c
>> @@ -33,6 +33,7 @@
>>  static int nocompress = 0;
>>  static int noresume = 0;
>>  static int resume_wait = 0;
>> +static int resume_delay = 0;
>
> These static variables get zeroed needlessly and checkpatch actually
> warns about that. Maybe fix that up while you're there?

yes. right. i initilized it to 0 to keep consistent coding style with
the context because there were other variants doing that.
i'd like to delete all initialization together as a seperate patch. Or
do you want to do that?

>
> Thanks.
>
> --
> Regards/Gruss,
>    Boris.
-barry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/