lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 10 Oct 2011 10:52:50 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: Pelle Windestam <pelle@...destam.se> Cc: Greg Kroah-Hartman <gregkh@...e.de>, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/1] drivers: staging: rts_pstor fixed checkpatch warnings On Mon, Oct 10, 2011 at 07:42:17AM +0200, Pelle Windestam wrote: > -static struct pci_device_id rtsx_ids[] = { > - { 0x10EC, 0x5208, PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_OTHERS << 16, 0xFF0000 }, > - { 0x10EC, 0x5209, PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_OTHERS << 16, 0xFF0000 }, > - { 0x10EC, 0x5288, PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_OTHERS << 16, 0xFF0000 }, > +static DEFINE_PCI_DEVICE_TABLE(rtsx_ids) = { > + { 0x10EC, 0x5208, PCI_ANY_ID, PCI_ANY_ID, > + PCI_CLASS_OTHERS << 16, 0xFF0000 }, > + { 0x10EC, 0x5209, PCI_ANY_ID, PCI_ANY_ID, > + PCI_CLASS_OTHERS << 16, 0xFF0000 }, > + { 0x10EC, 0x5288, PCI_ANY_ID, PCI_ANY_ID, > + PCI_CLASS_OTHERS << 16, 0xFF0000 }, > { 0, }, > }; This looked nicer in the original version. I know that checkpatch complains but in the end, checkpatch is just a perl script. It's less sentient than a squirrel. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists