linux-kernel - Re: [PATCH v7 3/3] arm/tegra: device tree support for ventana board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111010080109.GQ9003@tbergstrom-lnx.Nvidia.com>
Date:	Mon, 10 Oct 2011 11:01:09 +0300
From:	Peter De Schrijver <pdeschrijver@...dia.com>
To:	Stephen Warren <swarren@...dia.com>
CC:	Russell King <linux@....linux.org.uk>,
	Erik Gilling <konkers@...roid.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	Colin Cross <ccross@...roid.com>,
	Olof Johansson <olof@...om.net>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v7 3/3] arm/tegra: device tree support for ventana board

On Fri, Oct 07, 2011 at 08:04:34PM +0200, Stephen Warren wrote:
> Peter De Schrijver wrote at Monday, October 03, 2011 7:19 AM:
> 
> ...
> > diff --git a/arch/arm/boot/dts/tegra-ventana.dts b/arch/arm/boot/dts/tegra-ventana.dts
> ...
> > +	chosen {
> > +		bootargs = "vmalloc=192M video=tegrafb console=ttyS0,115200n8 root=/dev/ram rdinit=/sbin/init";
> 
> It might be nice to make this identical to what Harmony and Seaboard have here.
> 
> Still, it doesn't matter a lot, since I (and I imagine most people) have
> to edit this command-line to point at the correct partition for my disks
> anyway; eventually, U-Boot should be providing/re-writing this property
> too.
> 
> ...
> > diff --git a/arch/arm/mach-tegra/board-dt.c b/arch/arm/mach-tegra/board-dt.c
> ...
> > -	if (of_machine_is_compatible("nvidia,harmony"))
> > -		harmony_pinmux_init();
> > -	else if (of_machine_is_compatible("nvidia,seaboard"))
> > -		seaboard_pinmux_init();
> > +	for (i = 0; i < ARRAY_SIZE(pinmux_configs); i++) {
> > +		if (of_machine_is_compatible(pinmux_configs[i].machine)) {
> > +			pinmux_configs[i].init();
> > +			break;
> > +		}
> > +	}
> > +
> > +	if (i == ARRAY_SIZE(pinmux_configs))
> > +		printk(KERN_WARNING "Unknown platform! Pinmuxing not initialized\n");
> 
> Should that be WARN() instead of printk?

pr_warning() might be better. Or do we want a backtrace and a tainted kernel
in this case? 

Cheers,

Peter.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/