lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 10 Oct 2011 11:49:48 +0300
From:	Felipe Balbi <balbi@...com>
To:	Klaus Schwarzkopf <schwarzkopf@...sortherm.de>
Cc:	balbi@...com, gregkh@...e.de, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, sshtylyov@...mvista.com
Subject: Re: [PATCH v3] usb: add new usb gadget for ACM and mass storage

Hi,

On Mon, Oct 10, 2011 at 10:33:01AM +0200, Klaus Schwarzkopf wrote:
> >>+static struct usb_device_descriptor device_desc = {
> >>+	.bLength =		sizeof device_desc,
> >>+	.bDescriptorType =	USB_DT_DEVICE,
> >>+
> >>+	.bcdUSB =		cpu_to_le16(0x0200),
> >>+
> >>+	.bDeviceClass =		USB_CLASS_COMM,
> >>+	.bDeviceSubClass =	0,
> >>+	.bDeviceProtocol =	0,
> 
> Should bDeviceClass, bDeviceSubClass, and bDeviceProtocol have the
> same value like in the file multi.c?
> 
> 	.bDeviceClass =		USB_CLASS_MISC /* 0xEF */,
> 	.bDeviceSubClass =	2,
> 	.bDeviceProtocol =	1,

maybe, you gotta check CDC and MSC specs to find out.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)

Powered by blists - more mailing lists