linux-kernel - Re: linux-next: build warnings after merge of the writeback tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111011093308.GA1690@localhost>
Date:	Tue, 11 Oct 2011 17:33:08 +0800
From:	Wu Fengguang <fengguang.wu@...el.com>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: build warnings after merge of the writeback tree

On Tue, Oct 11, 2011 at 05:27:36PM +0800, Stephen Rothwell wrote:
> Hi,
> 
> On Tue, 11 Oct 2011 17:17:25 +0800 Wu Fengguang <fengguang.wu@...el.com> wrote:
> >
> > On Tue, Oct 11, 2011 at 04:57:04PM +0800, Stephen Rothwell wrote:
> > > 
> > > After merging the writeback tree, today's linux-next build (powerpc
> > > allnoconfig) produced these warnings:
> > > 
> > > mm/page-writeback.c: In function 'bdi_position_ratio':
> > > mm/page-writeback.c:622:3: warning: comparison of distinct pointer types lacks a cast [enabled by default]
> > > page-writeback.c:635:4: warning: comparison of distinct pointer types lacks a cast [enabled by default]
> > > 
> > > Introduced by commits 6c14ae1e92c7 ("writeback: dirty position control")
> > > and 8927f66c4ede ("writeback: dirty position control - bdi reserve area").
> > 
> > Ah sorry!  The below patch should fix it. Shall I update the original
> > commits in place, or append this patch as a new commit?
> 
> That choice is up to you as the maintainer of that tree.  Either works
> for me (appending is easier for you and me, and the warning is not a
> problem as far as bisection is concerned).

Got it!

> > Fix powerpc compile warnings
> > 
> > mm/page-writeback.c: In function 'bdi_position_ratio':
> > mm/page-writeback.c:622:3: warning: comparison of distinct pointer types lacks a cast [enabled by default]
> > page-writeback.c:635:4: warning: comparison of distinct pointer types lacks a cast [enabled by default]
> > 
> > Signed-off-by: Wu Fengguang <fengguang.wu@...el.com>
> 
> If you do keep it separate, you could add a
> 
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> 
> above your SOB line.

OK!

Thanks,
Fengguang

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/