linux-kernel - Re: [PATCH 1/1] staging: panel: Fixed checkpatch warning about simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Oct 2011 12:11:31 +0200
From:	Pelle Windestam <pelle@...destam.se>
To:	Pelle Windestam <iceaway@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, Jiri Kosina <trivial@...nel.org>
Subject: Re: [PATCH 1/1] staging: panel: Fixed checkpatch warning about simple_strtoul()

On Tue, Aug 30, 2011 at 8:29 PM, Pelle Windestam <iceaway@...il.com> wrote:
> Fixed the checkpatch warning about sing simple_strtoul instead of
> kstrtoul() in panel.c.
>
> Signed-off-by: Pelle Windestam <iceaway@...il.com>
> ---
>  drivers/staging/panel/panel.c |   10 ++++------
>  1 files changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
> index b303b7e..4683d5f 100644
> --- a/drivers/staging/panel/panel.c
> +++ b/drivers/staging/panel/panel.c
> @@ -1179,16 +1179,14 @@ static inline int handle_lcd_special_code(void)
>                        break;
>
>                while (*esc) {
> -                       char *endp;
> -
>                        if (*esc == 'x') {
>                                esc++;
> -                               lcd_addr_x = simple_strtoul(esc, &endp, 10);
> -                               esc = endp;
> +                               if (kstrtoul(esc, 10, &lcd_addr_x) < 0)
> +                                       break;
>                        } else if (*esc == 'y') {
>                                esc++;
> -                               lcd_addr_y = simple_strtoul(esc, &endp, 10);
> -                               esc = endp;
> +                               if (kstrtoul(esc, 10, &lcd_addr_y) < 0)
> +                                       break;
>                        } else
>                                break;
>                }
> --
> 1.7.3.4
>
>

Was there any reason for not accepting this patch?

//Pelle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/