| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 11 Oct 2011 15:16:31 +0100 From: Dimitris Papastamos <dp@...nsource.wolfsonmicro.com> To: Mark Brown <broonie@...nsource.wolfsonmicro.com> Cc: Axel Lin <axel.lin@...il.com>, linux-kernel@...r.kernel.org, Liam Girdwood <lrg@...com>, alsa-devel@...a-project.org Subject: Re: [PATCH] ASoC: Writing register default value for the reset register On Tue, Oct 11, 2011 at 02:31:18PM +0100, Mark Brown wrote: > On Tue, Oct 11, 2011 at 01:33:05PM +0100, Dimitris Papastamos wrote: > > On Tue, Oct 11, 2011 at 05:55:00PM +0800, Axel Lin wrote: > > > The WM8983 can be reset by performing a write of any value to > > > the software reset register. > > > > - ret = snd_soc_write(codec, WM8983_SOFTWARE_RESET, 0x8983); > > > + ret = snd_soc_write(codec, WM8983_SOFTWARE_RESET, 0); > > > We should probably just handle the reset register specially during > > resume. > > I really don't think it's worth the code complexity to add special > handling like that, this is a trivial patch which avoids the need for > any extra infrastructure. Aw I thought this code was using the old style open coded syncing functions, which would be trivial and perhaps idiomatic to simply check for the reset register and continue. Thanks, Dimitris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists