linux-kernel - RE: [PATCH v8 3/3] arm/tegra: device tree support for ventana board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <74CDBE0F657A3D45AFBB94109FB122FF173BE19AB0@HQMAIL01.nvidia.com>
Date:	Tue, 11 Oct 2011 09:36:04 -0700
From:	Stephen Warren <swarren@...dia.com>
To:	Peter De Schrijver <pdeschrijver@...dia.com>,
	Peter De Schrijver <pdeschrijver@...dia.com>
CC:	Russell King <linux@....linux.org.uk>,
	Colin Cross <ccross@...roid.com>,
	Erik Gilling <konkers@...roid.com>,
	Olof Johansson <olof@...om.net>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
Subject: RE: [PATCH v8 3/3] arm/tegra: device tree support for ventana board

Peter De Schrijver wrote at Tuesday, October 11, 2011 4:45 AM:
> Change-Id: I5ed18750e6a8aa3242dae4bcd7165cfd819356d2

You probably want to remove that.

...
> diff --git a/arch/arm/mach-tegra/board-dt.c b/arch/arm/mach-tegra/board-dt.c
...
> +	if (i == ARRAY_SIZE(pinmux_configs))
> +		WARN(1, "Unknown platform! Pinmuxing not initialized\n");

Sorry to keep picking on this, but shouldn't that be simply:

		WARN(i == ARRAY_SIZE(pinmux_configs),
			"Unknown platform! Pinmuxing not initialized\n");

-- 
nvpublic

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/