linux-kernel - Re: [01/38] PCI: Set PCI-E Max Payload Size on fabric

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAErSpo6JFTm4y35Nz7aNUgM3ynX52fM1-AwX7OTOwm3cminv1Q@mail.gmail.com>
Date:	Tue, 11 Oct 2011 12:14:05 -0600
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Benjamin LaHaise <bcrl@...ck.org>
Cc:	Greg KH <gregkh@...e.de>, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org, stable-review@...nel.org,
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	alan@...rguk.ukuu.org.uk, Jon Mason <mason@...i.com>,
	Jesse Barnes <jbarnes@...tuousgeek.org>
Subject: Re: [01/38] PCI: Set PCI-E Max Payload Size on fabric

On Tue, Oct 11, 2011 at 11:20 AM, Benjamin LaHaise <bcrl@...ck.org> wrote:
> Hello Greg,
>
> On Tue, Oct 11, 2011 at 10:55:11AM -0600, Greg KH wrote:
>> --- a/drivers/pci/pci.c
>> +++ b/drivers/pci/pci.c
>> @@ -77,6 +77,8 @@ unsigned long pci_cardbus_mem_size = DEF
>>  unsigned long pci_hotplug_io_size  = DEFAULT_HOTPLUG_IO_SIZE;
>>  unsigned long pci_hotplug_mem_size = DEFAULT_HOTPLUG_MEM_SIZE;
>>
>> +enum pcie_bus_config_types pcie_bus_config = PCIE_BUS_PERFORMANCE;
>> +
>
> This version of the patch incorrectly defaults to the new performance
> mode.  Since we haven't even had that code in the 3.1 release yet, I don't
> think it is suitable for a stable release.  This patch should be revised
> to a version with default set to safe/don't-touch mode if it is to be
> included.

It's not obvious that this fits the criteria for -stable
(Documentation/stable_kernel_rules.txt).

For example, I can't tell what real problem this fixes.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/