linux-kernel - Re: [PATCH 1/5 v13] arm: omap: usb: ehci and ohci hwmod structures for omap4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1110111315030.1664@utopia.booyaka.com>
Date:	Tue, 11 Oct 2011 13:17:03 -0600 (MDT)
From:	Paul Walmsley <paul@...an.com>
To:	Felipe Balbi <balbi@...com>
cc:	Alan Stern <stern@...land.harvard.edu>,
	"Munegowda, Keshava" <keshava_mgowda@...com>,
	linux-usb@...r.kernel.org, linux-omap@...r.kernel.org,
	linux-kernel@...r.kernel.org, khilman@...com, b-cousson@...com,
	gadiyar@...com, sameo@...ux.intel.com, parthab@...ia.ti.com,
	tony@...mide.com, johnstul@...ibm.com, vishwanath.bs@...com,
	Greg KH <greg@...ah.com>
Subject: Re: [PATCH 1/5 v13] arm: omap: usb: ehci and ohci hwmod structures
 for omap4

Hi

On Tue, 11 Oct 2011, Felipe Balbi wrote:

> On Tue, Oct 11, 2011 at 12:52:05PM -0600, Paul Walmsley wrote:
>
> > On Tue, 11 Oct 2011, Felipe Balbi wrote:
> > 
> > > maybe, but let's go with EXPORT_SYMBOL_GPL(). My only concern is that
> > > this IP comes from synopsys, and I'm not really keen on adding
> > > OMAP-specific, integration-related knowledge on a driver which was
> > > supposed to be reusable ;-)
> > >
> > > But at least for the time being, I guess that's what we need to do ;-)
> > 
> > Which IP is coming from Synopsys - the TLL ?  The EXPORT_SYMBOL approach 
> 
> TLL and UHH are OMAP-only wrappers. EHCI and OHCI are Synopsys IPs for
> all I know.

Ah, I see.

> > shouldn't add anything OMAP-specific to the TLL driver.  So the exported 
> > symbols should still be usable by drivers on other SoCs.  But perhaps I am 
> > misunderstanding your point?
> 
> A bit :-)
> 
> EHCI/OHCI will need to ask TLL to enable TLL clock, because it's
> EHCI/OHCI who configure the port. Unless I misunderstood what Keshava
> did (and no, I didn't just read the code, too lazy :-)

The calls to the TLL driver only need to go into the OMAP-specific 
ehci-omap.c and ohci-omap3.c wrappers, as far as I can see.  So I don't 
think there's a need to modify the generic OHCI/EHCI drivers...


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/