linux-kernel - Re: [PATCH] pata_scc: add proper cable detection method

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111011205415.1d5708af@lxorguk.ukuu.org.uk>
Date:	Tue, 11 Oct 2011 20:54:15 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Cc:	Jeff Garzik <jgarzik@...ox.com>, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pata_scc: add proper cable detection method

On Tue, 11 Oct 2011 20:07:24 +0200
Bartlomiej Zolnierkiewicz <bzolnier@...il.com> wrote:

> From: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
> Subject: [PATCH] pata_scc: add proper cable detection method
> 
> Use standard ata_cable_80wire() method for the cable detection,
> as a bonus this allows us to use the default ->prereset method.

What documentation have you got that confirms that the hardcoding is not
needed. It goes back to the original code and I see nothing saying that
the device has standard PC style cable detect.

You should also I think cc the Toshiba maintainers
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/