linux-kernel - Re: [PATCH 2/2] Staging: comedi: fix printk and line over 80

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <21386.1318368870@turing-police.cc.vt.edu>
Date:	Tue, 11 Oct 2011 17:34:30 -0400
From:	Valdis.Kletnieks@...edu
To:	Ravishankar Karkala Mallikarjunayya 
	<ravishankar.km@...enturtles.in>
Cc:	gregkh@...e.de, wfp5p@...ginia.edu, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] Staging: comedi: fix printk and line over 80

On Mon, 10 Oct 2011 19:28:53 +0530, Ravishankar Karkala Mallikarjunayya said:
> This patch fixes a  printk and line over 80 charcter found by the
> checkpatch.pl tool

> @@ -503,7 +512,7 @@ static int probe(struct comedi_device *dev, const struct comedi_devconfig *it)
>  		}
>  	}
>  
> -	printk("cb_pcimdda: No supported ComputerBoards/MeasurementComputing "
> +	pr_err("cb_pcimdda: No supported ComputerBoards/MeasurementComputing "
>  	       "card found at the requested position\n");
>  	return -ENODEV;
>  }

As long as we're changing this code, should we be splicing the two parts of the
string back together?  (And yes, that *does* trump the 80-col rule)

Content of type "application/pgp-signature" skipped