linux-kernel - Re: [PATCH] irq: Add EXPORT_SYMBOL to function of irq generic-chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 12 Oct 2011 11:25:30 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@...esas.com>
cc:	linux-kernel@...r.kernel.org, mingo@...nel.org
Subject: Re: [PATCH] irq: Add EXPORT_SYMBOL to function of irq generic-chip

On Wed, 12 Oct 2011, Nobuhiro Iwamatsu wrote:

> Although some functions of of irq generic-chip can be used,
> since EXPORT_SYMBOL is not specified, it cannot use.

This does not make sense. In which context they can't be used?

> This is revised that EXPORT_SYMBOL can be added and referred
> to in functions.

EXPORT_SYMBOL_GPL if at all please.

And I'd rather avoid the exports, except those

> +EXPORT_SYMBOL(irq_alloc_generic_chip);
> +EXPORT_SYMBOL(irq_setup_generic_chip);
> +EXPORT_SYMBOL(irq_setup_alt_chip);
> +EXPORT_SYMBOL(irq_remove_generic_chip);

which are really necessary. To gain access to the various helper
functions we're better off to create a data structure with function
pointers.

struct irq_gc_functions {
       void (* irq_gc_noop)(...);
       ...
};

Instantiate this structure in kernel/irq/generic-chip.c, statically
initialize it with pointers to those helper functions and export that
data structure. That's way more efficient than having the overhead of
the symbol export for each of the functions.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/