linux-kernel - Re: [PATCH 3/3] pata_sil680: minor CodingStyle fixups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E957080.6020102@mvista.com>
Date:	Wed, 12 Oct 2011 14:48:32 +0400
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
CC:	Jeff Garzik <jgarzik@...ox.com>, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] pata_sil680: minor CodingStyle fixups

Hello.

On 11-10-2011 22:21, Bartlomiej Zolnierkiewicz wrote:

> From: Bartlomiej Zolnierkiewicz<bzolnier@...il.com>
> Subject: [PATCH] pata_sil680: minor CodingStyle fixups

> Signed-off-by: Bartlomiej Zolnierkiewicz<bzolnier@...il.com>
> ---
>   drivers/ata/pata_sil680.c |   58 ++++++++++++++++++++++++++--------------------
>   1 file changed, 33 insertions(+), 25 deletions(-)

> Index: b/drivers/ata/pata_sil680.c
> ===================================================================
> --- a/drivers/ata/pata_sil680.c
> +++ b/drivers/ata/pata_sil680.c
[...]
> @@ -265,12 +266,19 @@ static u8 sil680_init_chip(struct pci_de
>   	pci_write_config_dword(pdev, 0xB8, 0x43924392);
>   	pci_write_config_dword(pdev, 0xBC, 0x40094009);
>
> -	switch(tmpbyte&  0x30) {
> -		case 0x00: printk(KERN_INFO "sil680: 100MHz clock.\n");break;
> -		case 0x10: printk(KERN_INFO "sil680: 133MHz clock.\n");break;
> -		case 0x20: printk(KERN_INFO "sil680: Using PCI clock.\n");break;
> -		/* This last case is _NOT_ ok */
> -		case 0x30: printk(KERN_ERR "sil680: Clock disabled ?\n");
> +	switch (tmpbyte&  0x30) {
> +	case 0x00:
> +		printk(KERN_INFO "sil680: 100MHz clock.\n");
> +		break;
> +	case 0x10:
> +		printk(KERN_INFO "sil680: 133MHz clock.\n");
> +		break;
> +	case 0x20:
> +		printk(KERN_INFO "sil680: Using PCI clock.\n");
> +		break;

    pr_info() here and above?

> +	/* This last case is _NOT_ ok */
> +	case 0x30:
> +		printk(KERN_ERR "sil680: Clock disabled ?\n");

    pr_err()? Or checkpatch.pl doesn't complain about it (I forgot)?

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/