linux-kernel - Re: [PATCH 06/13] jfs: remove unnecessary nlink setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E95B1C1.3080507@oracle.com>
Date:	Wed, 12 Oct 2011 10:26:57 -0500
From:	Dave Kleikamp <dave.kleikamp@...cle.com>
To:	Miklos Szeredi <miklos@...redi.hu>
CC:	viro@...IV.linux.org.uk, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, jack@...e.cz, hch@...radead.org,
	akpm@...ux-foundation.org, toshi.okajima@...fujitsu.com,
	mszeredi@...e.cz
Subject: Re: [PATCH 06/13] jfs: remove unnecessary nlink setting

On 10/12/2011 09:48 AM, Miklos Szeredi wrote:
> From: Miklos Szeredi <mszeredi@...e.cz>
> 
> alloc_inode() initializes i_nlink to 1.  Remove unnecessary
> re-initialization.
> 
> Signed-off-by: Miklos Szeredi <mszeredi@...e.cz>

Acked-by: Dave Kleikamp <dave.kleikamp@...cle.com>

> ---
>  fs/jfs/super.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/jfs/super.c b/fs/jfs/super.c
> index 06c8a67..a44eff0 100644
> --- a/fs/jfs/super.c
> +++ b/fs/jfs/super.c
> @@ -485,7 +485,6 @@ static int jfs_fill_super(struct super_block *sb, void *data, int silent)
>  		goto out_unload;
>  	}
>  	inode->i_ino = 0;
> -	inode->i_nlink = 1;
>  	inode->i_size = sb->s_bdev->bd_inode->i_size;
>  	inode->i_mapping->a_ops = &jfs_metapage_aops;
>  	insert_inode_hash(inode);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/