| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <201110121727.46778.bzolnier@gmail.com> Date: Wed, 12 Oct 2011 17:27:46 +0200 From: Bartlomiej Zolnierkiewicz <bzolnier@...il.com> To: Alan Cox <alan@...rguk.ukuu.org.uk> Cc: Jeff Garzik <jgarzik@...ox.com>, linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] pata_cs5520: remove incorrect warning message Alan Cox wrote: > On Tue, 11 Oct 2011 20:00:44 +0200 > Bartlomiej Zolnierkiewicz <bzolnier@...il.com> wrote: > > > From: Bartlomiej Zolnierkiewicz <bzolnier@...il.com> > > Subject: [PATCH] pata_cs5520: remove incorrect warning message > > > > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com> > > Nothing incorrect about it. It's rather useful information for debugging > CS5520 problems. Users should never see it - and I've not seen it > occuring on any standard VSA releases. > > Do you have any examples of it confusing users or even showing up ? This driver dooen't even use DMA mode so warning about forcing the setting may be puzzling. In addition we do the same thing cs5520_reinit_one() but without warning the user this time. Thus removal of the warning makes it easier for *_reinit_one() replacement by ->init_host method later (patch is ready for this). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists