linux-kernel - Re: [alsa-devel] [PATCH 2/9] ASoC: da7210: Add support for line input and mic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1318496138.12107.435.camel@matrix>
Date:	Thu, 13 Oct 2011 14:25:38 +0530
From:	Ashish Chavan <ashish.chavan@...tcummins.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
CC:	<lrg@...com>, alsa-devel <alsa-devel@...a-project.org>,
	David Dajun Chen <david.chen@...semi.com>,
	<kuninori.morimoto.gx@...esas.com>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [alsa-devel] [PATCH 2/9] ASoC: da7210: Add support for line
 input and mic

On Wed, 2011-10-12 at 15:53 +0100, Mark Brown wrote:
> On Wed, Oct 12, 2011 at 08:28:12PM +0530, Ashish Chavan wrote:
> 
> > +static const char *da7210_mic_bias_voltage_txt[] = {
> > +	"1.5", "1.6", "2.2", "2.3"
> > +};
> > +
> > +static const struct soc_enum da7210_mic_bias =
> > +	SOC_ENUM_SINGLE(DA7210_MIC_L, 4, 4, da7210_mic_bias_voltage_txt);
> > +
> 
> This shouldn't be application controllable, it's a board property and if
> it needs to be managed it's likely to be by in kernel things like
> accessory detection.  We do have some older drivers that do this but
> they're not good.  Use platform data.
> 

In that case I think, it's better to remove it from here.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/