linux-kernel - [PATCH] Platform: Detect samsung laptop quirk when initial level is zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPjEYUJ6YtJGdhgxZioDaUbBm0-GWe4j1D5viE3S1zY+Pp+fjA@mail.gmail.com>
Date:	Thu, 13 Oct 2011 06:42:01 -0400
From:	John Serock <john.serock@...il.com>
To:	gregkh@...e.de
Cc:	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
	jasonbstubbs@...il.com
Subject: [PATCH] Platform: Detect samsung laptop quirk when initial level is zero

From: John Serock <john.serock@...il.com>

This patch depends on the "Platform: Brightness quirk for samsung
laptop driver" patch from Jason Stubbs. This patch adds a check for an
initial brightness level of 0; if the level is 0, this patch changes
the brightness level to 1 before the driver attempts to detect the
brightness quirk.

The Samsung N150 netbook experiences the brightness quirk. Without
Jason's patch, the only brightness levels available on the N150 are 0,
1, and 8. This patch ensures that, when the initial brightness level
is 0, the samsang-laptop driver detects the brightness quirk on the
N150, thereby making brightness levels 0 through 8 available.

Signed-off-by: John Serock <john.serock@...il.com>

---
diff -uprN a/drivers/platform/x86/samsung-laptop.c
b/drivers/platform/x86/samsung-laptop.c
--- a/drivers/platform/x86/samsung-laptop.c	2011-10-12 13:51:15.030779179 -0400
+++ b/drivers/platform/x86/samsung-laptop.c	2011-10-12 13:51:32.746867045 -0400
@@ -404,8 +404,9 @@ static int get_brightness(struct backlig

 static void check_for_stepping_quirk(void)
 {
-	u8 initial_level = read_brightness();
+	u8 initial_level;
 	u8 check_level;
+	u8 orig_level = read_brightness();

 	/*
 	 * Some laptops exhibit the strange behaviour of stepping toward
@@ -414,6 +415,11 @@ static void check_for_stepping_quirk(voi
 	 * around in set_brightness.
 	 */

+	if (orig_level == 0)
+		set_brightness(1);
+
+	initial_level = read_brightness();
+
 	if (initial_level <= 2)
 		check_level = initial_level + 2;
 	else
@@ -427,7 +433,7 @@ static void check_for_stepping_quirk(voi
 		pr_info("enabled workaround for brightness stepping quirk\n");
 	}

-	set_brightness(initial_level);
+	set_brightness(orig_level);
 }

 static int update_status(struct backlight_device *bd)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/