linux-kernel - Re: [PATCH] nfs-utils: mount: really return from errno test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <40D1A40C-BE0C-4AE0-857D-05531615748E@oracle.com>
Date:	Thu, 13 Oct 2011 10:53:05 -0400
From:	Chuck Lever <chuck.lever@...cle.com>
To:	Hamo <hamo.by@...il.com>
Cc:	linux-nfs@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nfs-utils: mount: really return from errno test

What was the presenting problem?  Is there a bugzilla report I can look at?

On Oct 11, 2011, at 5:44 AM, Hamo wrote:

> We should only try next address family if we meet ECONNREFUSED or EHOSTUNREACH
> for v4 or ECONNREFUSED or EOPNOTSUPP or EHOSTUNREACH for v3v2.
> Before, only a break in swich can not make the program out of for loop.
> 
> Signed-off-by: Yang Bai <hamo.by@...il.com>
> ---
> utils/mount/stropts.c |    6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/utils/mount/stropts.c b/utils/mount/stropts.c
> index 314a806..4032bf3 100644
> --- a/utils/mount/stropts.c
> +++ b/utils/mount/stropts.c
> @@ -665,9 +665,10 @@ static int nfs_try_mount_v3v2(struct nfsmount_info *mi)
> 		case EHOSTUNREACH:
> 			continue;
> 		default:
> -			break;
> +			goto out;
> 		}
> 	}
> +out:
> 	return ret;
> }
> 
> @@ -751,9 +752,10 @@ static int nfs_try_mount_v4(struct nfsmount_info *mi)
> 		case EHOSTUNREACH:
> 			continue;
> 		default:
> -			break;
> +			goto out;
> 		}
> 	}
> +out:
> 	return ret;
> }
> 
> -- 
> 1.7.1
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Chuck Lever
chuck[dot]lever[at]oracle[dot]com




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/