linux-kernel - Re: [PATCH 1/1] x86, e820: Remove direct mapping of reserved space for HT hole around 1TB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E97094F.6050900@zytor.com>
Date:	Thu, 13 Oct 2011 08:52:47 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Andreas Herrmann <herrmann.der.user@...glemail.com>
CC:	Jacob Shin <jacob.shin@....com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
	x86@...nel.org, Yinghai Lu <yinghai@...nel.org>
Subject: Re: [PATCH 1/1] x86, e820: Remove direct mapping of reserved space
 for HT hole around 1TB

On 10/13/2011 02:57 AM, Andreas Herrmann wrote:
>
> So what is the point in including address space below TOM2 not backed
> with memory in kernel's direct mapping? For similar reserved space
> before 4GB we don't do this.
>
> Instead of barfing, some more constructive feedback would be
> appreciated.
>

Ok, that's a BUG, plain and simple, and a very serious one (for exactly 
the reason you just described.)  We should NEVER have cachable mappings 
for a RESERVED region because it can have arbitrary side effects, so the 
fact that that happens at all is the real problem and it MUST be addressed.

So I'm not arguing that it is not a problem for you (it is a real and 
serious problem), but I would like to see it addressed correctly, which 
is to exclude these memory regions from direct mapping just as we do for 
< 4 GB.  That way the fix applies to any RESERVED region.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/