linux-kernel - Re: [Patch 1/2] gpio-pca953x: fix gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACxGe6ut+8ERLgQ3BcnqkWKgt2uYNHwk4baP8sjtAXVuJDe7CA@mail.gmail.com>
Date:	Thu, 13 Oct 2011 13:52:41 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Hartmut Knaack <knaack.h@....de>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [Patch 1/2] gpio-pca953x: fix gpio_base and add verbosity

On Thu, Oct 13, 2011 at 1:46 PM, Grant Likely <grant.likely@...retlab.ca> wrote:
> On Tue, Oct 11, 2011 at 12:22:45AM +0200, Hartmut Knaack wrote:
>> gpio_base was set to 0 if no system platform data or open firmware
>> platform data was provided. This led to conflicts, if any other gpiochip
>> with a gpiobase of 0 was instantiated already. Setting it to -1 will
>> automatically use the first one available.
>>
>> Signed-off-by: Hartmut Knaack <knaack.h@....de>
>> -------------------------------------------------------------
>
> Corrupt patch (linewrap and whitespace damage).  Please check your mailer.

I applied it manually though.

g.

>
>> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
>> index c43b8ff..ae479fd 100644
>> --- a/drivers/gpio/gpio-pca953x.c
>> +++ b/drivers/gpio/gpio-pca953x.c
>> @@ -577,6 +577,7 @@ pca953x_get_alt_pdata(struct i2c_client *client, int
>> *gpio_base, int *invert)
>>  void
>>  pca953x_get_alt_pdata(struct i2c_client *client, int *gpio_base, int
>> *invert)
>>  {
>> +  *gpio_base = -1;
>>  }
>>  #endif
>>
>>
>



-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/