linux-kernel - Re: [PATCH] i7core_edac: fix erroneous size of static array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E9744C1.5040903@redhat.com>
Date:	Thu, 13 Oct 2011 17:06:25 -0300
From:	Mauro Carvalho Chehab <mchehab@...hat.com>
To:	Niklas Söderlund <niso@....se>
CC:	Borislav Petkov <bp@...64.org>,
	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] i7core_edac: fix erroneous size of static array

Em 13-10-2011 17:03, Niklas Söderlund escreveu:
> On 10/13/2011 08:56 PM, Borislav Petkov wrote:
> 
>> On Thu, Oct 13, 2011 at 02:24:54PM -0400, Niklas Söderlund wrote:
>>> Signed-off-by: Niklas Söderlund <niso@....se>
>>> ---
>>>  drivers/edac/i7core_edac.c |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/drivers/edac/i7core_edac.c b/drivers/edac/i7core_edac.c
>>> index 70ad892..e0f6096 100644
>>> --- a/drivers/edac/i7core_edac.c
>>> +++ b/drivers/edac/i7core_edac.c
>>> @@ -441,7 +441,7 @@ static inline int numrow(u32 row)
>>>  
>>>  static inline int numcol(u32 col)
>>>  {
>>> -	static int cols[8] = {
>>> +	static int cols[4] = {
>>>  		1 << 10, 1 << 11, 1 << 12, -EINVAL,
>>>  	};
>>
>> Even better,
>>
>> you could completely remove the number in the [] since the {}
>> initializer contains all array elements already. In this and the
>> remaining arrays in those small inline functions.
>>
> 
> 
> Thanks for the feedback!
> 
> What would be the correct way of submitting an updated patch? Sending it
> in this mail thread or create a new one?

[PATCHv2] is the usual way. if you're using git, you may use the msgid of
the first message as a reference for the version 2.

Mauro.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/