linux-kernel - Re: [PATCH 1/3] ASoC: alc5623: Convert codec->hw_read to regmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111013233414.GB21690@sirena.org.uk>
Date:	Fri, 14 Oct 2011 00:34:14 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Arnaud Patard <arnaud.patard@...-net.org>,
	Liam Girdwood <lrg@...com>, alsa-devel@...a-project.org
Subject: Re: [PATCH 1/3] ASoC: alc5623: Convert codec->hw_read to
 regmap_read

On Fri, Oct 14, 2011 at 07:29:33AM +0800, Axel Lin wrote:

> I check the regmap code, it seems cache_bypsss is only set
> if map->cache_type == REGCACHE_NONE or by regcache_cache_bypass().

That's in regmap.  Any ASoC drivers which haven't been converted to
directly use regmap will still use the ASoC copy of the cache code.

> +       regcache_cache_bypass(codec->control_data, true);
> +       for (i = 0 ; i < codec->driver->reg_cache_size ; i += step) {
> +               regmap_read(codec->control_data, i, &val);
> +               cache[i] = val;
> +       }
> +       regcache_cache_bypass(codec->control_data, false);

This is what a driver which uses regmap directly should do.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/