linux-kernel - Re: [PATCH] HID: usbhid: enable remote wakeup for mice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201110141018.28446.oneukum@suse.de>
Date:	Fri, 14 Oct 2011 10:18:28 +0200
From:	Oliver Neukum <oneukum@...e.de>
To:	Benson Leung <bleung@...omium.org>
Cc:	jkosina@...e.cz, stern@...land.harvard.edu,
	linux-usb@...r.kernel.org, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: usbhid: enable remote wakeup for mice

Am Freitag, 14. Oktober 2011, 09:54:48 schrieb Benson Leung:
> This patch enables remote wakeup by default on USB mouse
> devices. This only covers USB mice that support
> the boot protocol. See commit 3d61510f for the
> equivalent patch for USB keyboard devices.

This doesn't loo like a very good idea.
Firstly your patch introduces gratious change in the hid driver.
Secondly you are changing the usbmouse driver, which is to
be used under special circumstances only, only.
Thirdly a fundamental change like that needs a commit entry
explaining the reason for the change.

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/