| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <alpine.LNX.2.00.1110141127240.14768@pobox.suse.cz> Date: Fri, 14 Oct 2011 11:30:20 +0200 (CEST) From: Jiri Kosina <jkosina@...e.cz> To: Terry Lambert <tlambert@...omium.org> Cc: linux-input@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] Driver for Primax keyboards violating USB HID spec On Thu, 13 Oct 2011, Terry Lambert wrote: > Hi Jiri; thanks for looking so promptly! > > The routine right now just caches the hi->input for later look up > during the raw input report, which I suppose could be done inline on > each report with a couple function calls. Well yes, but even in px_raw_event() the px_device *px is only initialized, but never used. So I'd just remove the whole px_device thing altogether, I don't think it's needed. > I don't have one of the folding keyboards people are complaining about > not being able to use for Android tablets on hand, or the unhappy Dell > Inspiron laptop, both of which use the controller That's to explain > why the remapping code and the product ID for them are missing from > this patch. I see. I'd like to ask you though to only submit patches containing code that is actually used. Whenever the remapping part is needed for some other keyboard, we'll just add it at the very time it's needed. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists