linux-kernel - Re: [PATCH 10/21] tomoyo: drop unused Kconfig symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201110142202.CHH39010.OHJLFFtQOSMVOF@I-love.SAKURA.ne.jp>
Date:	Fri, 14 Oct 2011 22:02:20 +0900
From:	Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
To:	pebolle@...cali.nl, linux-security-module@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, takedakn@...data.co.jp
Subject: Re: [PATCH 10/21] tomoyo: drop unused Kconfig symbols

Paul Bolle wrote:
>  security/tomoyo/Kconfig |   24 ------------------------
>  1 files changed, 0 insertions(+), 24 deletions(-)

Thank you for finding. Below patch (for 3.2) fixes this error.
I'll carry below patch on TOMOYO's website (for 3.1).
--------------------
[PATCH] TOMOYO: Fix unused kernel config option.

CONFIG_SECURITY_TOMOYO_MAX_ACCEPT_ENTRY and
CONFIG_SECURITY_TOMOYO_MAX_AUDIT_LOG introduced by commit 0e4ae0e0
"TOMOYO: Make several options configurable." were by error not used.

Reported-by: Paul Bolle <pebolle@...cali.nl>
Signed-off-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
---
diff --git a/security/tomoyo/common.c b/security/tomoyo/common.c
index 902650b..48bb7af 100644
--- a/security/tomoyo/common.c
+++ b/security/tomoyo/common.c
@@ -502,8 +502,10 @@ static struct tomoyo_profile *tomoyo_assign_profile
 			TOMOYO_CONFIG_WANT_REJECT_LOG;
 		memset(ptr->config, TOMOYO_CONFIG_USE_DEFAULT,
 		       sizeof(ptr->config));
-		ptr->pref[TOMOYO_PREF_MAX_AUDIT_LOG] = 1024;
-		ptr->pref[TOMOYO_PREF_MAX_LEARNING_ENTRY] = 2048;
+		ptr->pref[TOMOYO_PREF_MAX_AUDIT_LOG] =
+			CONFIG_SECURITY_TOMOYO_MAX_AUDIT_LOG;
+		ptr->pref[TOMOYO_PREF_MAX_LEARNING_ENTRY] =
+			CONFIG_SECURITY_TOMOYO_MAX_ACCEPT_ENTRY;
 		mb(); /* Avoid out-of-order execution. */
 		ns->profile_ptr[profile] = ptr;
 		entry = NULL;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/