linux-kernel - Re: [PATCH] HID: usbhid: enable remote wakeup for mice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1110141106270.2036-100000@iolanthe.rowland.org>
Date:	Fri, 14 Oct 2011 11:09:32 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Benson Leung <bleung@...omium.org>
cc:	Jiri Kosina <jkosina@...e.cz>, Oliver Neukum <oneukum@...e.de>,
	<linux-usb@...r.kernel.org>, <linux-input@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] HID: usbhid: enable remote wakeup for mice

On Fri, 14 Oct 2011, Benson Leung wrote:

> Thanks for the prompt response.
> 
> My initial reasoning was to set as default the wakeup behavior so a
> mouse button press would wake the system. I am well aware that most if
> not all mice don't support wake on move, but at least wake on button
> press would have been more desirable than doing nothing.

I'm sorry, I misunderstood the purpose of the original patch.  Probably 
read it too quickly -- I thought you were enabling autosuspend rather 
than wakeup.

Enabling wakeup by default has its own problems.  Some mice do send
wakeup requests when they are moved.  You wouldn't want a stray motion
or unintentional touch to wake up a sleeping system.  Or at least, a
lot of people wouldn't want that.

> Anyway, I'll solve this problem on my system by writing to wakeup
> property on device attach. Consider my change abandoned.

That seems like the best approach.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/