linux-kernel - Re: [PATCH v2] Documentation/power: Update docs about suspend and CPU hotplug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1110141140080.2036-100000@iolanthe.rowland.org>
Date:	Fri, 14 Oct 2011 11:44:48 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	"Srivatsa S. Bhat" <srivatsa.bhat@...ux.vnet.ibm.com>
cc:	"Rafael J. Wysocki" <rjw@...k.pl>, <rdunlap@...otime.net>,
	<len.brown@...el.com>, <pavel@....cz>, <a.p.zijlstra@...llo.nl>,
	<linux-pm@...r.kernel.org>, <linux-doc@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] Documentation/power: Update docs about suspend and
 CPU hotplug

On Fri, 14 Oct 2011, Srivatsa S. Bhat wrote:

> Update the documentation about the interaction between the suspend (S3) call
> path and the CPU hotplug infrastructure.
> This patch focusses only on the activities of the freezer, cpu hotplug and
> the notifications involved. It outlines how regular CPU hotplug differs from
> the way it is invoked during suspend and also tries to explain the locking
> involved.
> 
> v2: Clarified the question, to emphasize that the document explains only
>     the difference (and similarity) in the two code paths but not what happens
>     when race conditions occur between them.

Drawing the two diagrams in parallel, the way this does, carries a very
strong implication that the events being described happen in parallel.  
It really would be much better to have two separate diagrams and point
out the common portions.

Also, the document should discuss the issues involved in CPU hotplug.  
In particular, what happens if the CPUs are not all the same, or if the 
requiring differing microcodes.  And whether or not the microcode needs 
to get reloaded (presumably only after hibernation, not after suspend).
And what happens when a CPU is hot-unplugged and replaced with a 
differeing CPU which is then hot-plugged.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/