linux-kernel - Re: [PATCH] PCI / PM: Remove unnecessary error variable from acpi_dev_run

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111014090758.23aabe2d@jbarnes-desktop>
Date:	Fri, 14 Oct 2011 09:07:58 -0700
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Bjorn Helgaas <bhelgaas@...gle.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Linux PM mailing list <linux-pm@...ts.linux-foundation.org>,
	ACPI Devel Mailing List <linux-acpi@...r.kernel.org>,
	linux-pci@...r.kernel.org
Subject: Re: [PATCH] PCI / PM: Remove unnecessary error variable from
 acpi_dev_run_wake()

On Wed, 28 Sep 2011 21:44:36 +0200
"Rafael J. Wysocki" <rjw@...k.pl> wrote:
> ---
> From: Rafael J. Wysocki <rjw@...k.pl>
> Subject: PCI / PM: Return correct result from acpi_dev_run_wake()
> 
> The result returned by acpi_dev_run_wake() is always either -EINVAL
> or -ENODEV, while obviously it should return 0 on success.  The
> problem is that the leftover error variable, that's not really used
> in the function, is initialized with -ENODEV and then returned
> without modification.
> 
> To fix this issue remove the error variable from acpi_dev_run_wake()
> and make the function return 0 on success as appropriate.
> 
> Signed-off-by: Rafael J. Wysocki <rjw@...k.pl>

Applied to linux-next, thanks.

-- 
Jesse Barnes, Intel Open Source Technology Center

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)