linux-kernel - Re: [PATCH 09/10] USB: move to dma_transfer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1318608811.1546.438.camel@vkoul-udesk3>
Date:	Fri, 14 Oct 2011 21:43:31 +0530
From:	Vinod Koul <vinod.koul@...ux.intel.com>
To:	Jassi Brar <jaswinder.singh@...aro.org>
Cc:	dan.j.williams@...el.com, linux-kernel@...r.kernel.org,
	21cnbao@...il.com, rmk@....linux.org.uk,
	Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: [PATCH 09/10] USB: move to dma_transfer_direction

On Fri, 2011-10-14 at 16:31 +0530, Jassi Brar wrote:
> On 14 October 2011 11:08, Vinod Koul <vinod.koul@...el.com> wrote:
> >
> > diff --git a/drivers/usb/musb/ux500_dma.c b/drivers/usb/musb/ux500_dma.c
> > index ef4333f..9587bdd 100644
> > --- a/drivers/usb/musb/ux500_dma.c
> > +++ b/drivers/usb/musb/ux500_dma.c
> > @@ -112,7 +112,7 @@ static bool ux500_configure_channel(struct dma_channel *channel,
> >        struct musb_hw_ep *hw_ep = ux500_channel->hw_ep;
> >        struct dma_chan *dma_chan = ux500_channel->dma_chan;
> >        struct dma_async_tx_descriptor *dma_desc;
> > -       enum dma_data_direction direction;
> > +       enum dma_transfer_direction direction;
> >        struct scatterlist sg;
> >        struct dma_slave_config slave_conf;
> >        enum dma_slave_buswidth addr_width;
> > @@ -132,7 +132,7 @@ static bool ux500_configure_channel(struct dma_channel *channel,
> >        sg_dma_address(&sg) = dma_addr;
> >        sg_dma_len(&sg) = len;
> >
> > -       direction = ux500_channel->is_tx ? DMA_TO_DEVICE : DMA_FROM_DEVICE;
> > +       slave_dirn = ux500_channel->is_tx ? MEM_TO_DEV : DEV_TO_MEM;
> >        addr_width = (len & 0x3) ? DMA_SLAVE_BUSWIDTH_1_BYTE :
> >                                        DMA_SLAVE_BUSWIDTH_4_BYTES;
> >
> s/slave_dirn/direction ?
Oops, some how much scripts seems to have failed to build usb, hence
didnt find. Thanks for pointing out.

I will revise this and split into two as requested by Filipe


-- 
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/