linux-kernel - Re: [PATCH 3/3] pata_sil680: minor CodingStyle fixups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4E986738.9050504@pobox.com>
Date:	Fri, 14 Oct 2011 12:45:44 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
CC:	Sergei Shtylyov <sshtylyov@...sta.com>, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] pata_sil680: minor CodingStyle fixups

On 10/12/2011 07:03 AM, Alan Cox wrote:
>
>>
>>> +	/* This last case is _NOT_ ok */
>>> +	case 0x30:
>>> +		printk(KERN_ERR "sil680: Clock disabled ?\n");
>>
>>      pr_err()? Or checkpatch.pl doesn't complain about it (I forgot)?
>
> dev_ would be even better but that seems to be a separate thing. The
> existing patch is still a move in the right direction.

agreed x 2

To be specific, it should be

	dev_err(&pdev->dev

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/