linux-kernel - Re: [PATCH] sysfs: add per pci device msi[x] irq listing (v5)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111014173143.GB15946@hmsreliant.think-freely.org>
Date:	Fri, 14 Oct 2011 13:31:43 -0400
From:	Neil Horman <nhorman@...driver.com>
To:	Jesse Barnes <jbarnes@...tuousgeek.org>
Cc:	Bjorn Helgaas <bhelgaas@...gle.com>,
	Stefan Richter <stefanr@...6.in-berlin.de>,
	linux-kernel@...r.kernel.org, Greg Kroah-Hartman <gregkh@...e.de>,
	linux-pci@...r.kernel.org, Matthew Wilcox <matthew@....cx>
Subject: Re: [PATCH] sysfs: add per pci device msi[x] irq listing (v5)

On Fri, Oct 14, 2011 at 09:21:48AM -0700, Jesse Barnes wrote:
> On Thu, 6 Oct 2011 14:08:18 -0400
> Neil Horman <nhorman@...driver.com> wrote:
> 
> > This patch adds a per-pci-device subdirectory in sysfs called:
> > /sys/bus/pci/devices/<device>/msi_irqs
> > 
> > This sub-directory exports the set of msi vectors allocated by a given
> > pci device, by creating a numbered sub-directory for each vector beneath
> > msi_irqs.  For each vector various attributes can be exported.  Currently the
> > only attribute is called mode, which tracks the operational mode of that vector
> > (msi vs. msix)
> > 
> 
> Ok this adds new ABI in the form of sysfs files so I want to make sure
> it's ok.
> 
> Matthew has dreams of a more sophisticated MSI-X management scheme, but
> it sounds to me like that will mostly affect the driver interfaces and
> shouldn't be incompatible with the sysfs scheme you propose here.
> 
> If so, great, we can pull this in and maybe one day someone will
> implement better MSI-X support.
> 
> If not, I'd like to hear objections now; Neil has been responsive and
> fixed several issues.  I don't want to block his patch unless we have
> something concrete that it conflicts with.
> 
> Thanks,
> -- 
> Jesse Barnes, Intel Open Source Technology Center


Thanks Jesse, Greg, Bjorn, I appreciate all the input here.
Neil
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/