linux-kernel - Re: Problems with Kconfig select across directories

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4E98BD9F.2090503@panasas.com>
Date:	Sat, 15 Oct 2011 00:54:23 +0200
From:	Boaz Harrosh <bharrosh@...asas.com>
To:	Michal Marek <mmarek@...e.cz>
CC:	Paul Bolle <pebolle@...cali.nl>,
	Trond Myklebust <Trond.Myklebust@...app.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	NFS list <linux-nfs@...r.kernel.org>
Subject: Re: Problems with Kconfig select across directories

On 10/15/2011 12:45 AM, Michal Marek wrote:
> On 15.10.2011 00:27, Boaz Harrosh wrote:
>> On 10/15/2011 12:03 AM, Michal Marek wrote:
>>> On 14.10.2011 16:35, Boaz Harrosh wrote:
>>>> This does not work. The ORE is not compiled and MODPOST complains.
>>>> (Given EXOFS_FS is not selected since then it will work)
>>>
>>> fs/Makefile only visits fs/exofs if CONFIG_EXOFS_FS is set.
>>
>> Bingo. Right on the money. With below patch it works. I'll think
>> about it some more and submit.
>>
>> Thanks
>> ---
>> exofs/ore: Select fs/exofs/ folder in Makefile also for ORE only compilation
>>
>> If any thing from fs/exofs is set the ORE will be selected. So conditionally
>> include fs/exofs in fs/Makefile on ORE set and not EXOFS_FS
> ...
>> --- a/fs/Makefile
>> +++ b/fs/Makefile
>> @@ -120,6 +120,6 @@ obj-$(CONFIG_DEBUG_FS)		+= debugfs/
>>  obj-$(CONFIG_OCFS2_FS)		+= ocfs2/
>>  obj-$(CONFIG_BTRFS_FS)		+= btrfs/
>>  obj-$(CONFIG_GFS2_FS)           += gfs2/
>> -obj-$(CONFIG_EXOFS_FS)          += exofs/
>> +obj-$(CONFIG_ORE)		+= exofs/
> 
> Note that changing it to obj-y is also valid. And perhaps more obvious.
> 
> Michal

Thanks. You read my thoughts. The naming would be off with my change.
I'll take your advise and send a patch to Al on Monday.

Cheers
Boaz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/