linux-kernel - Re: [PATCH v2 14/29] sparc/PCI: convert to pci_create_root

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20111014.004915.1737071409851288288.davem@davemloft.net>
Date:	Fri, 14 Oct 2011 00:49:15 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	bhelgaas@...gle.com
Cc:	linux-pci@...r.kernel.org, linux-arch@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 14/29] sparc/PCI: convert to pci_create_root_bus()
 for correct root bus resources

From: David Miller <davem@...emloft.net>
Date: Fri, 14 Oct 2011 00:46:54 -0400 (EDT)

> From: Bjorn Helgaas <bhelgaas@...gle.com>
> Date: Thu, 13 Oct 2011 22:28:18 -0600
> 
>> Convert from pci_create_bus() to pci_create_root_bus().  This way the root
>> bus resources are correct immediately.  This patch doesn't fix anything
>> because sparc fixed them before scanning the bus, but it makes it more
>> consistent with other architectures.
>> 
>> I didn't work out where pcibios_fixup_bus() is called.  I don't see a
>> use of pci_scan_bus(), pci_scan_bus_parented(), or pci_scan_child_bus().
>> 
>> CC: David S. Miller <davem@...emloft.net>
>> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>
> 
> The pcibios_fixup_bus() case here (sparc64) is an artifact from when
> we actually probed the PCI config space for device probing on sparc64,
> and pci_bus_probe() would invoke it.
> 
> Unfortunately we can't delete this function now even though it's empty
> with your changes, because drivers/pci/probe.o is unconditionally
> linked into the kernel when CONFIG_PCI even when an architecture
> (such as sparc64) doesn't use the majority of the code in it.

Sorry, forgot to give this an ACK :-)

Acked-by: David S. Miller <davem@...emloft.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/