linux-kernel - Re: [v2 2/4] platform: (TS-5500) add GPIO support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111014061427.GD19874@elte.hu>
Date:	Fri, 14 Oct 2011 08:14:27 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Cc:	x86@...nel.org,
	Jerome Oufella <jerome.oufella@...oirfairelinux.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org
Subject: Re: [v2 2/4] platform: (TS-5500) add GPIO support


* Ingo Molnar <mingo@...e.hu> wrote:

> 
> * Vivien Didelot <vivien.didelot@...oirfairelinux.com> wrote:
> 
> > From: Jerome Oufella <jerome.oufella@...oirfairelinux.com>
> > 
> > Signed-off-by: Vivien Didelot <vivien.didelot@...oirfairelinux.com>
> 
> Same question as for the other patch, was this intended to be:
> 
>   From: Jerome Oufella <jerome.oufella@...oirfairelinux.com>
>  
>   Signed-off-by: Jerome Oufella <jerome.oufella@...oirfairelinux.com>
>   Signed-off-by: Vivien Didelot <vivien.didelot@...oirfairelinux.com>
> 
> ?

Ping? These patches cannot be advanced without a proper SOB sequence.

Also, with the attached config i get this build failure:

 arch/x86/built-in.o: In function `ts5500_adc_probe':
 ts5500_adc.c:(.devinit.text+0x1e1): undefined reference to `hwmon_device_register'
 make: *** [.tmp_vmlinux1] Error 1

Which kind of build failure is typically some sort of 
modular/built-in corner case combination:

 CONFIG_HWMON=m
 CONFIG_HWMON_VID=m
 # CONFIG_HWMON_DEBUG_CHIP is not set
 CONFIG_THERMAL_HWMON=y
 CONFIG_TS5500=y
 # CONFIG_TS5500_GPIO is not set
 CONFIG_TS5500_LED=y
 CONFIG_TS5500_ADC=y
 CONFIG_LEDS_GPIO=m
 CONFIG_LEDS_TRIGGER_GPIO=m

And is generally fixed by cleaner/better Kconfig dependencies.

Thanks,

	Ingo

View attachment "config" of type "text/plain" (66547 bytes)