linux-kernel - Re: [PATCH v2] mach-ep93xx: break out GPIO driver specifics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111015204129.GZ21648@n2100.arm.linux.org.uk>
Date:	Sat, 15 Oct 2011 21:41:30 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Mika Westerberg <mika.westerberg@....fi>
Cc:	Linus Walleij <linus.walleij@...ricsson.com>,
	Ryan Mallon <rmallon@...il.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	linux-kernel@...r.kernel.org,
	Grant Likely <grant.likely@...retlab.ca>,
	Hartley Sweeten <hsweeten@...ionengravers.com>,
	Lee Jones <lee.jones@...aro.org>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2] mach-ep93xx: break out GPIO driver specifics

On Sat, Oct 15, 2011 at 09:18:08PM +0300, Mika Westerberg wrote:
> I just tried to compile latest linux-next and due to missing <mach/gpio.h> I
> get:
> 
> In file included from include/linux/gpio.h:18:0,
>                  from drivers/gpio/gpiolib.c:10:
> /home/westeri/devel/kernel/linux/arch/arm/include/asm/gpio.h:5:23: fatal error: mach/gpio.h: No such file or directory
> compilation terminated.
> make[2]: *** [drivers/gpio/gpiolib.o] Error 1
> 
> It looks like arch/arm/include/asm/gpio.h wants to have <mach/gpio.h>. Any idea
> how to fix this?

Hmm.  It shouldn't have been deleted - Linus' patch leaves the file
empty rather than deleting it.

However, as I had to use GNU patch to apply Linus' patch (as git apply
wouldn't because of fuzz), it doesn't understand that, so it removed it.
This is where having an /* empty */ comment avoids that kind of thing,
just like I've done for all the other mach/gpio.h which became empty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/