linux-kernel - Re: Q.: Why does tty_ioctl.c: set_termios return EINTR instead of ERESTARTSYS?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111015102559.3e85b32d@lxorguk.ukuu.org.uk>
Date:	Sat, 15 Oct 2011 10:25:59 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	Godmar Back <godmar@...il.com>, linux-kernel@...r.kernel.org,
	Greg KH <gregkh@...e.de>
Subject: Re: Q.: Why does tty_ioctl.c: set_termios return EINTR instead of
 ERESTARTSYS?

 Is there a particular reason why it cannot be made restartable?
> 
> EINTR is used when there is no way to rollback already performed
> actions. In this case, a flush could be performed. (This holds only for
> TCSETSF, TCSETSF2 and similar.) So I think this is the reason we cannot
> return ERESTARTSYS.
> 
> However I CCed tty fellows, they may have a different opinion.

I don't actually know. I think Linus or Ted T'so were still doing the tty
code that long back. Ted also did some compliance testing on it way back
when (1995 or so ?)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/