linux-kernel - Re: [PATCH v2.1 1/7] crypto: GnuPG based MPI lib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.00.1110151125280.24994@tundra.namei.org>
Date:	Sat, 15 Oct 2011 11:28:15 +1100 (EST)
From:	James Morris <jmorris@...ei.org>
To:	Dmitry Kasatkin <dmitry.kasatkin@...el.com>
cc:	linux-security-module@...r.kernel.org,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
	zohar@...ux.vnet.ibm.com, dhowells@...hat.com,
	herbert@...dor.hengli.com.au
Subject: Re: [PATCH v2.1 1/7] crypto: GnuPG based MPI lib - source files
 (part 1)

On Fri, 14 Oct 2011, Dmitry Kasatkin wrote:

> +MPI mpi_alloc(unsigned nlimbs)
> +{
> +	MPI a;
> +
> +	a = (MPI) kmalloc(sizeof *a, GFP_KERNEL);

Generally, typedef structs are frowned upon in the kernel.  I'd prefer to 
see this (and any others) changed to a normal type.

Also, kmalloc return values do not need to be cast, they're void *.

> +EXPORT_SYMBOL(mpi_alloc);

New interfaces should be EXPORT_SYMBOL_GPL.


-- 
James Morris
<jmorris@...ei.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/