linux-kernel - Re: [PATCH 1/4] TTY: drop driver reference in tty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111016182815.GA14883@us.ibm.com>
Date:	Sun, 16 Oct 2011 11:28:15 -0700
From:	Sukadev Bhattiprolu <sukadev@...ux.vnet.ibm.com>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	gregkh@...e.de, linux-kernel@...r.kernel.org, jirislaby@...il.com,
	stable@...nel.org, Sukadev Bhattiprolu <sukadev@...ibm.com>,
	Alan Cox <alan@...rguk.ukuu.org.uk>
Subject: Re: [PATCH 1/4] TTY: drop driver reference in tty_open fail path

Jiri Slaby [jslaby@...e.cz] wrote:
| When tty_driver_lookup_tty fails in tty_open, we forget to drop a
| reference to the tty driver. This was added by commit 4a2b5fddd5 (Move
| tty lookup/reopen to caller).
| 
| Fix that by adding tty_driver_kref_put to the fail path.

Arg. Sorry about that. Thanks for spotting/fixing it.

| 
| I will refactor the code later. This is for the ease of backporting to
| stable.
| 
| Introduced-in: v2.6.28-rc2
| Signed-off-by: Jiri Slaby <jslaby@...e.cz>
| Cc: stable@...nel.org
| Cc: Sukadev Bhattiprolu <sukadev@...ibm.com>
| Cc: Alan Cox <alan@...rguk.ukuu.org.uk>
| Cc: Greg Kroah-Hartman <gregkh@...e.de>

Acked-by: Sukadev Bhattiprolu <sukadev@...ux.vnet.ibm.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/