linux-kernel - Re: sony-laptop driver: Volume keys on Sony Vaio TX3 don't work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111016213800.GA12703@kamineko.org>
Date:	Mon, 17 Oct 2011 06:38:01 +0900
From:	Mattia Dongili <malattia@...ux.it>
To:	Valdis.Kletnieks@...edu
Cc:	John Hughes <john@...vaedi.com>, linux-kernel@...r.kernel.org,
	Stelian Pop <stelian@...ies.net>,
	platform-driver-x86 <platform-driver-x86@...r.kernel.org>
Subject: Re: sony-laptop driver: Volume keys on Sony Vaio TX3 don't work

On Sun, Oct 16, 2011 at 02:20:18PM -0400, Valdis.Kletnieks@...edu wrote:
> On Sun, 16 Oct 2011 19:45:14 +0200, John Hughes said:
> > >> Even though sony-laptop has code to handle the volume-up/volume-down 
> > >> keys they don't work.  Pressing volume-down gets treated as 
> > >> SONYPI_EVENT_PKEY_P1 and volume-up as SONYPI_EVENT_PKEY_P2.
> 
> > Here's a patch that makes the volume keys work for me.  Tested on 
> > current git
> 
> > diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
> 
> Do we know if this is applicable to all Sony laptops, or only a few busticated
> models?

I believe the latter is the case, the old A series also had this
problem. Of course applying the patch will break other models (SZ is one
I'm sure about) so there is no actual winner here unless we figure out
how to properly decode keys on sonypi models (this problem is
specifically related to two phase hotkey decoding, see the irq handler).
...I don't have any such old laptop anymore with me.

-- 
mattia
:wq!

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)